-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] sort-prop-types
: Check for undefined before accessing node.typeAnnotation.typeAnnotation
#3779
Conversation
…ypeAnnotation.typeAnnotation`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need a regression test before this fix can land.
@tylerlaprade can you share the code that errored in your linked comment? |
@ljharb, in a file with a
|
3e02d91
to
99d6a36
Compare
node.typeAnnotation
sort-prop-types
: Check for undefined before accessing node.typeAnnotation.typeAnnotation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3779 +/- ##
==========================================
- Coverage 97.62% 97.49% -0.14%
==========================================
Files 134 134
Lines 9617 9634 +17
Branches 3488 3496 +8
==========================================
+ Hits 9389 9393 +4
- Misses 228 241 +13 ☔ View full report in Codecov by Sentry. |
Thanks for adding the test case! It looks like some snapshots need to be updated, but when I |
99d6a36
to
67d73aa
Compare
we don't use snapshots :-) it's just that some of the test jobs don't support fragments. i switched it to a div instead. |
Fixes the bug reported in this comment